microsoft / microsoft/TypeScript
Better error for semicolon after decorator
Open
Nobody has claimed this yet.
Domain: Error Messages
Help Wanted
Suggestion
- Dominant language
- Go
- Stars
- 111k
- Forks
- 14.3k
- Avg merge
- 2d 4h
- Merged PRs (30d)
- 132
Description
TypeScript Version: 2.7.0-dev.20171230
Code
import { component } from "babyioc";
import { Member } from "./Effects";
class Example {
@component(Member);
public readonly member: Member;
}
Expected behavior:
file.ts(6,23): error TSXXXX: Semicolons not allowed after decorators.
Actual behavior:
file.ts(6,23): error TS1146: Declaration expected.
Not very important IMO, but a little confusing.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Reproduce the decorator example in file.ts using the reported TypeScript version and compare the current diagnostic with the expected semicolon-specific error. Trace the parser or diagnostic path reached after a decorator and semicolon; done means this example reports that semicolons are not allowed after decorators rather than TS1146.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- compilers
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 45/100