microsoft / microsoft/TypeScript

strictPropertyInitialization with subclasses that refine the types of properties

Open
#20,911 4 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

In Discussion Suggestion
Dominant language
Go
Stars
111k
Forks
14.3k
Avg merge
2d 4h
Merged PRs (30d)
132

Description

TypeScript Version: 2.7.0-dev.20171226

Code

class A {
  x: {y: string} = {y: 'y'};
}

class B extends A {
  x: {y: string, z?: number};
}

Expected behavior:
I expected this not to warn because A#x is assignable to B#x.

Actual behavior:

index.ts(6,3): error TS2564: Property 'x' has no initializer and is not definitely assigned in the constructor.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the minimal subclass example with strictPropertyInitialization enabled using the TypeScript compiler. Trace the type-checking path that reports TS2564 for the refined property, then add a regression test showing the diagnostic is omitted when the base initializer satisfies the subtype; run the relevant compiler tests to confirm existing initialization checks still pass.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
compilers
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.