microsoft / microsoft/TypeScript
strictPropertyInitialization with subclasses that refine the types of properties
Nobody has claimed this yet.
- Dominant language
- Go
- Stars
- 111k
- Forks
- 14.3k
- Avg merge
- 2d 4h
- Merged PRs (30d)
- 132
Description
TypeScript Version: 2.7.0-dev.20171226
Code
class A {
x: {y: string} = {y: 'y'};
}
class B extends A {
x: {y: string, z?: number};
}
Expected behavior:
I expected this not to warn because A#x is assignable to B#x.
Actual behavior:
index.ts(6,3): error TS2564: Property 'x' has no initializer and is not definitely assigned in the constructor.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reproducing the minimal subclass example with strictPropertyInitialization enabled using the TypeScript compiler. Trace the type-checking path that reports TS2564 for the refined property, then add a regression test showing the diagnostic is omitted when the base initializer satisfies the subtype; run the relevant compiler tests to confirm existing initialization checks still pass.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- compilers
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 38/100