microsoft / microsoft/TypeScript
JSDoc trying to parse tag names where tag names aren't possible
Open
@sandersn is already working on this.
Since Nov 14, 2017.
Domain: JavaScript
Domain: JSDoc
In Discussion
Suggestion
- Dominant language
- Go
- Stars
- 111k
- Forks
- 14.3k
- Avg merge
- 2d 4h
- Merged PRs (30d)
- 132
Description
TypeScript Version: 2.7.0-dev.201xxxxx
Code
/**
* When concatenated with a string, this automatically concatenates the user's mention instead of the Member object.
* @returns {string}
* @example
* // Logs: Hello from <@123456789>!
* console.log(`Hello from ${member}!`);
*/
toString() {
return `<@${this.nickname ? '!' : ''}${this.user.id}>`;
}
Expected behavior:
No error
Actual behavior:
node_modules/discord.js/src/structures/GuildMember.js(511,28): error TS1003: Identifier expected.
Error on @123456789 - we probably shouldn't be looking for tags in the middle of a line.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.