microsoft / microsoft/TypeScript
Type narrowing with foo.constructor
Open
Nobody has claimed this yet.
Awaiting More Feedback
Suggestion
- Dominant language
- Go
- Stars
- 111k
- Forks
- 14.3k
- Avg merge
- 2d 4h
- Merged PRs (30d)
- 132
Description
TypeScript Version: 2.3.1
Code
class FooTask {
foo: number;
}
class BarTask {
bar: number;
}
type taskType = FooTask|BarTask;
function createEvent(task: taskType) {
if (task instanceof FooTask) {
task.foo; // Works.
}
switch (task.constructor) {
case FooTask:
task.foo; // Fails.
}
}
It would be nice if the second worked like the first; narrowed the type of task appropriately.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Use the provided FooTask/BarTask example with TypeScript 2.3.1 to reproduce the difference between instanceof and task.constructor narrowing. Trace the compiler's type-narrowing path for the switch and compare it with the instanceof case. Done means task.foo is accepted in the FooTask branch without weakening the existing narrowing behavior.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- compilers
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 45/100