microsoft / microsoft/TypeScript
Determine when isDeclaration and isDeclarationName should check for special property assignments
Open
Nobody has claimed this yet.
Infrastructure
- Dominant language
- Go
- Stars
- 111k
- Forks
- 14.3k
- Avg merge
- 2d 4h
- Merged PRs (30d)
- 132
Description
TypeScript Version: nightly (2.4.0-dev.20170523)
Currently neither function handles special JS assignments such as exports.x = .... We should review each case where we use these functions and see if special assignments need to be handled.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating isDeclaration and isDeclarationName, then review each caller for cases involving special JavaScript assignments such as exports.x = .... Done means the relevant declaration checks consistently account for those assignments where appropriate, with coverage for the reviewed cases.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript, typescript
- Domain
- compilers
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100