microsoft / microsoft/TypeScript

Extra entries for JavaScript auto complete(intellisense) make no sense

Open
#15,679 5 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Committed Domain: JavaScript Domain: LS: Completion Lists Suggestion
Dominant language
Go
Stars
111k
Forks
14.3k
Avg merge
2d 4h
Merged PRs (30d)
132

Description

TypeScript Version: 2.2.1 / nightly (2.2.0-dev.201xxxxx)

Code
The following code in javascript:

/**
* @param {MessageActivity} activity
* @param {IConversationContext} context
*/
export function Prompt_beforeResponse(activity, context)
{
  // MessageActivity is defined in typescript definition provided to the editor as having 4 properties (attachements, text, speak, type). 
 // Typing activity. will show those for properties but also: 
 //     activity  - why should activity be under itself?
 //     context - why should the second parameter be under activity?
 //     IConversationContext - why would a type, that is not a property in any object be under activity?
 //     MessageActivity - same question as above
 //     onRun - why should a global function be under activity
 //     Prompt_when - same as above
 //     Prompt_beforeResponse - same question as above and this is the function itself


//  Here is another example. obj. should display only a and b, but it also shows activity, context, MessageActivity, IConversationContext, etc.
   /**
    * @type {{a: number, b: string }}
   */
   var obj = {};
   obj.
}
// A *self-contained* demonstration of the problem follows...

Expected behavior:
When a javascript type is not "any", i.e. when it is definded in jsdoc or in the typescript definition helper (See https://github.com/Microsoft/TypeScript/wiki/JavaScript-Language-Service-in-Visual-Studio#unsupported-patterns) only those defined members should be part of intellisense.
Even if the type is any, throwing everything on intellisense like that defeats the purpose of finding out what reasonably could be under the object.

Actual behavior:
A bunch of extra entries show up in intellisnese that make no sense for either typed or untyped scenarios, but it is specially bad for typed scenarios where some thought was put in place in what should appear in intellisense. Adding all those entries makes the intellisense feature less useful.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the JavaScript language service and the JSDoc-typed examples in the issue, reproducing completion results for activity. and obj. Compare the suggestions with the declared members and the expected behavior described in the report. Done means unrelated globals, parameters, types, and functions no longer appear as completions for typed JavaScript values.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript, typescript
Domain
developer-experience, tooling
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.