microsoft / microsoft/TypeScript
Flag boolean in comparison operator operands as errors
Open
Nobody has claimed this yet.
Good First Issue
Help Wanted
Suggestion
- Dominant language
- Go
- Stars
- 111k
- Forks
- 14.3k
- Avg merge
- 2d 4h
- Merged PRs (30d)
- 132
Description
From https://github.com/Microsoft/TypeScript/issues/15444#issuecomment-298055832
var x: boolean, y: boolean;
if (x > y) { // suspicious!
}
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by tracing the type-checking logic for comparison operators and reviewing existing diagnostics for invalid operand types. Use the boolean comparison example in the issue as the behavioral case; done means such comparisons are reported as errors without changing valid comparisons.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- compilers
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Active
- Clarity
- Mostly clear
- Newbie friendliness
- 55/100