microsoft / microsoft/TypeScript

Provide Format Options for JSX/TSX End of Tag Placement

Open
#12,539 1 comment 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Domain: Formatter Help Wanted Suggestion VS Code Tracked
Dominant language
Go
Stars
111k
Forks
14.3k
Avg merge
2d 4h
Merged PRs (30d)
132

Description

From https://github.com/Microsoft/vscode/issues/16018 @VanishingDante

For the following JSX/TSX code:

<div
    >
    <img
        />
</div>

The current formatting settings do nothing. There does not seem to be a way to control how the ending > is placed on lines.

We would like an additional formatting setting so that we can format the above code as:

<div>
    <img />
</div>

This formatting option would be helpful for elements with many attributes.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the JSX/TSX formatting entry point and the existing formatting settings that handle tag endings. Reproduce the examples in the issue and determine how a new option would control the placement of closing angle brackets; done when the requested formatting can be selected and produces the shown output.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript, typescript
Domain
tooling
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.