microsoft / microsoft/TypeScript

[Proposal] Display all properties (inherited or not) of a given class (in TypeScript)

Open
#10,752 18 comments 16 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Needs Proposal Suggestion VS Code Tracked
Dominant language
Go
Stars
111k
Forks
14.3k
Avg merge
2d 4h
Merged PRs (30d)
132

Description

From @yahiko00 on September 4, 2016 21:56

Visual Studio Code is a fantastic tool and I am really impressed by all its features despite being quite young.

There is a feature that does not still exists in VS Code which could be really convenient when we are forced to deal with big inheritance hierarchies.

This proposal is based on the TypeScript language, but I am quite sure this could apply to other OOP languages VS Code supports.

Overview of the Workflow

Let us assume we have a source file animal.ts like this:

// animal.ts

abstract class Animal {
    private dna: number;
    name: string;

    constructor(name: string) {
        this.dna = Math.random();
        this.name = name;
    }

    abstract shout(): string;
}

This file could be open or not in VS Code, but it is part of the current project.

Let us assume we have another source file bird.ts like this:

// bird.ts

class Bird extends Animal {
    constructor() {
        super();
        this.name = "Hector";
    }
    shout(): string {
        return "Cuicui!"; // sorry it is in French... I do not know how a bird shouts in English ^_^
    }
}

This file is open in VS Code.

What I would like to be able to do in VS Code is displaying all properties, inherited or not, available for the class Bird.

To do so, we could move the cursor on the Bird identifier, press F1 key, and run a new Display all inherited properties command.

This new command would open a new file in a new tab called Bird (all inherited properties).

In this example, the content of this file would be the following:

class Bird {
    private dna: number;
    name: string;

    super.constructor(name: string) {
        this.dna = Math.random();
        this.name = name;
    }

    constructor() {
        super();
        this.name = "Hector";
    }

    shout(): string {
        return "Cuicui!";
    }
}

The content of Bird (all inherited properties) has nothing to do with valid syntax. Its purpose is only informational.

Some informal rules

  • Attributes should be displayed first.
  • Type anotations should be rendered unchanged.
  • Access modifiers public, protected, private should be rendered unchanged.
  • Abstract methods which are not overriden should be rendered.
  • All versions of an overriden method should be rendered, with a concatenation of super prefixes to distinguish each version in the inheritance hierarchy. For instance super.method() would refer to immediate method()'s parent, whereas super.super.method() would refer to method()'s grand-parent, and so on.
  • Method()'s parent should be displayed before the method() itself.
  • The same rules for method() apply to constructor().

Copied from original issue: Microsoft/vscode#11526

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the proposal's animal.ts and bird.ts examples, then investigate the F1 command entry point in VS Code and how TypeScript inheritance information is exposed. Done would mean a command can display inherited and local properties, methods, constructors, and abstract members in the described informational format.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript, vscode
Domain
developer-experience, tooling
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
28/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.