Typescript syntax highlighting breaks after multi line crocodile bracket type assertion

Open
#983 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
45/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Stale
Tech stack
typescript, vscode
Domain
developer-experience, tooling

Research direction

Reproduce the issue by opening the supplied TypeScript example in VS Code with extensions disabled, then inspect the repository's TypeScript TextMate grammar files to trace the multiline angle-bracket assertion. Done means syntax highlighting resumes correctly after the assertion, including the following if statements and string literal.

Written by the indexing model from the issue text.

Description

Does this issue occur when all extensions are disabled?: Yes

  • VS Code Version: Version: 1.78.2 (Universal)
  • OS Version: macOS 13.4

Steps to Reproduce:

  1. past the following code into a file which has TypeScript set as the language
const req: { query: Record<string, unknown> } = { query: {id1: 'foo', id: 'bar'} };

const { id1, id2 } = <
  {
    id1: string;
    id2: string;
  }
>req.query;

if (id1) {
  throw new Error('syntax highlighting broke');
}

const backToNormal = 'yay';

if (id2) {
  throw new Error('syntax highlighting is back');
}

Screenshot was taken on an instance with all extensions disabled.
Notice how the highlighting breaks after the req.query for the following if statement and its contents.
Screenshot 2023-06-07 at 5 14 54 PM

Here is a second screenshot with different theme added. You can see it breaks in the same spot.
Screenshot 2023-06-07 at 5 15 38 PM

Dominant language
TypeScript
Stars
471
Forks
149
No merged PRs in 30d

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from microsoft/TypeScript-TmLanguage

All issues in microsoft/TypeScript-TmLanguage

Similar issues

More TypeScript issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.