microsoft / microsoft/TypeScript-TmLanguage

Incorrect TypeScript syntax highlighting with variable type starting on a new line

Open
#981 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
TypeScript
Stars
471
Forks
149
PR merge metrics
No merged PRs in 30d

Description

Does this issue occur when all extensions are disabled?: Yes

  • VS Code Version: 1.78.1
  • OS Version: Windows_NT x64 10.0.22621 (Windows 11)

Steps to Reproduce:
(This issue can also be reproduced in VSCode Web)

  1. Create new text file
  2. Select TypeScript language
  3. Paste the following code:
let a:
  number
for (;;);
  1. Syntax highlighting starting with 'for' is broken. It does not occur if type specifier is on the same line as variable declaration.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the issue in VS Code or VS Code Web using the provided TypeScript snippet, first with the type on a new line and then on the declaration line. Inspect the repository's TypeScript TextMate grammar files to find the rule responsible for the broken highlighting beginning at for; done means both forms highlight correctly.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
tooling
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.