microsoft / microsoft/TypeScript-TmLanguage

[Typescript] Broken arrow function signature highlighting

Open
#911 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
TypeScript
Stars
471
Forks
149
PR merge metrics
No merged PRs in 30d

Description

Does this issue occur when all extensions are disabled?: Yes

  • VS Code Version: 1.66.2
  • OS Version: Linux 5.17.5-arch1-1

Syntax highlighting breaks on arrow functions with return type being multiline tuple, works fine on function declarations.

Steps to Reproduce:

const foo = ({ a, b }: any): [
    el1: number,
    el2: string,
] => {
    a
    b
    return [1, '2']
}

Expected highlight:
Screenshot from 2022-05-05 13-52-26

Actual highlight:
Screenshot from 2022-05-05 13-52-53

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the TypeScript snippet in VS Code with extensions disabled, then inspect the repository’s TypeScript TextMate grammar files for the multiline tuple return-type rule. Done means arrow-function signatures with multiline labeled tuple return types highlight like equivalent function declarations without regressing the provided example.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
tooling
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.