microsoft / microsoft/TypeScript-TmLanguage

Broken syntax highlighting when the default import is named "from"

Open
#891 2 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Effort: Difficult limitation
Dominant language
TypeScript
Stars
471
Forks
149
PR merge metrics
No merged PRs in 30d

Description

TS and JS Grammar Extension version: latest

Code

import from from './from';

Visual output

Screen Shot 2021-11-05 at 15 18 51

If the name assigned to the default export is "from" then it gets highlighted improperly.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the issue with the TypeScript snippet import from from './from'; in the TS and JS Grammar Extension. Inspect the grammar rules that classify imports and the identifier from; it is done when this valid statement receives correct syntax highlighting without regressing ordinary imports.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
tooling
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.