microsoft / microsoft/TypeScript-TmLanguage

JavaScript Syntax Highlighter Broke

Open
#883 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
TypeScript
Stars
471
Forks
149
PR merge metrics
No merged PRs in 30d

Description

Does this issue occur when all extensions are disabled?: Yes/No

  • VS Code Version: 1.59.1
  • OS Version: Windows_NT x64 10.0.19043

Steps to Reproduce:

  1. Make a JavaScript File
  2. type in: for (const req of /require *\\( *["'\](.+?)["'`] *\)/.exec(fileCode).slice(1)) {}`
  3. some things in the brakets will be highlighted incorrectly

image

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the incorrect highlighting in VS Code 1.59.1 using the JavaScript regex shown in the issue, then inspect the TypeScript TextMate grammar files in this repository. Done means the relevant parts inside the regular expression are highlighted correctly without breaking the surrounding JavaScript syntax.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript, typescript
Domain
tooling
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.