microsoft / microsoft/TypeScript-TmLanguage

`override` modifier still looks off

Open
#881 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
TypeScript
Stars
471
Forks
149
PR merge metrics
No merged PRs in 30d

Description

Potentially as a continuation of #868, override still looks a little bit off compared to other modifiers, and I'm not sure if that's intentional.

image

image

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start in the repository's TextMate grammar files and inspect how the override modifier is scoped and styled relative to other modifiers. Compare the result with the two linked screenshots and the behavior of the related issue #868; done means override has the intended appearance without disrupting other modifier highlighting.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
tooling
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.