microsoft / microsoft/TypeScript-TmLanguage

Absence of color when using "in" keyword in terinary operators (JS)

Open
#869 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
TypeScript
Stars
471
Forks
149
PR merge metrics
No merged PRs in 30d

Description

  • VS Code Version:
  • OS Version:

Steps to Reproduce:

  1. Enter the following code:
    hello = type in _typeIs ? type : 'any'
    
  2. Notice the absence of color in some tokens (variables and string)
    Screen Shot 2021-04-05 at 11 04 54 AM

However, when removing in _typeIs, we get:

Screen Shot 2021-04-05 at 11 06 52 AM

Does this issue occur when all extensions are disabled?: Yes
Theme: Dark+ (default dark)

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the report in VS Code with extensions disabled using the shown JavaScript ternary expression, and compare its token colors with the version without in _typeIs. Done means variables and the string receive the expected syntax highlighting in the Dark+ theme; the issue does not name a grammar file or test to start from.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript, typescript
Domain
tooling
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.