microsoft / microsoft/TypeScript-TmLanguage

Regular expressions aren't properly highlighted in certain scenarios

Open
#853 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
TypeScript
Stars
471
Forks
149
PR merge metrics
No merged PRs in 30d

Description

in vscode 1.53.1

/foo/;
return /foo/;
throw /foo/;

yield* /foo/;
yield /foo/;
await /foo/;

export default /foo/;


if(_) /foo/;
else /foo/;

while(_) /foo/;

for(;;) /foo/;
for(_ in /foo/) /foo/;

with(_) /foo/;

do /foo/;
while(_);


void /foo/;
typeof /foo/;
/foo/ in /foo/;
/foo/ instanceof /foo/;
new /foo/;
!class extends /foo/ {};

/foo/[/foo/];
!/foo/;
~/foo/;
+/foo/;
-/foo/;
++/foo/;
--/foo/;
/foo/++;
/foo/--;

looks like this:

as can be seen, regular expressions aren't properly highlighted:

  • after throw/export default
  • after await/yield (but not yield*)
  • after while(), for(), with(), do, else (but not if())
  • after in/of (in for..in/for..of)
  • after void/typeof/new
  • as either operand of in/instanceof
  • after extends (in class)
  • after unary ++/--

worse yet, this can break the highlighting of surrounding code:

yield /[[]/;
if(1) {
	foo["bar"]();
	a: { break a; }
} else return 123;

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the supplied JavaScript snippets in VS Code, then locate the TypeScript TextMate grammar rules responsible for regular-expression literals. Compare highlighting in each listed context and in the nested example; done means the regexes and surrounding code are highlighted correctly without breaking later constructs.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript, typescript
Domain
tooling
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.