microsoft / microsoft/TypeScript-TmLanguage

javascript different highlighting when naming a class method `new`

Open
#815 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Awaiting More Feedback
Dominant language
TypeScript
Stars
471
Forks
149
PR merge metrics
No merged PRs in 30d

Description

class X {
	new() {}
	abc() {}
  }

Code_2020-04-02_15-40-38
1.43.2

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the JavaScript example in the issue and inspect the repository's TypeScript TextMate grammar files to find how class methods named new are tokenized. Compare the highlighting of new() with abc() in a supported editor. Done means both method names receive the expected consistent highlighting.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
tooling
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.