microsoft / microsoft/TypeScript-TmLanguage

Combination of optional operator and new line breaks syntax higlighting in function arguments

Open
#1,059 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
TypeScript
Stars
471
Forks
149
PR merge metrics
No merged PRs in 30d

Description

Code

// Syntax hilighting is INCORRECT ❌
const a = async (params?: {
  arg?: string | number;
  arg2?: string | number;
  arg3?: string | number;
}) => {
  return params;
};

// Syntax hilighting is CORRECT ✅
const b = async (params: {
  arg?: string | number;
  arg2?: string | number;
  arg3?: string | number;
}) => {
  return params;
};

// Syntax hilighting is CORRECT ✅
const c = async (params?: { arg?: string | number }) => {
  return params;
};

// Syntax hilighting is CORRECT ✅
const d = async (params: { arg?: string | number }) => {
  return params;
};
Image

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the issue with the TypeScript examples in the report using the repository's TextMate grammar in a supported editor. Inspect the grammar rules responsible for optional parameters, object-type members, and multiline function arguments. Done means the multiline optional-parameter example receives the same correct highlighting as the other examples.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
tooling
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.