microsoft / microsoft/TypeScript-TmLanguage

Highlighting of TypeScript method that returns a union

Open
#1,041 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
TypeScript
Stars
471
Forks
149
PR merge metrics
No merged PRs in 30d

Description

Does this issue occur when all extensions are disabled?: Yes/No

  • VS Code Version: 1.92.2
  • OS Version: elementary OS 7.1, based on Ubuntu 22.04.3 LTS

Steps to Reproduce:

  1. Create a new file and choose TypeScript as the language
  2. Paste the following code:
class Foo {
  foo():
    | string
    | Array<number> {
      const foo = 42;
      return [foo];
    }
}
  1. See that the highlighting is broken

image

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the issue in a TypeScript file using the provided class and multiline union return type, with extensions disabled. Investigate the TypeScript TextMate grammar used for syntax highlighting; done means the method and its union return type are highlighted correctly without breaking surrounding code.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
tooling
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.