microsoft / microsoft/TypeScript-TmLanguage

Return argument not colored properly if multiline

Open
#1,002 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
TypeScript
Stars
471
Forks
149
PR merge metrics
No merged PRs in 30d

Description

Type: Bug

When putting this into a TypeScript file:

type MyType<T> = { func: T };

function AFunction<T>(arg: T): MyType<T> {
    return { func: arg };
}

const x = AFunction<(arg: string) => unknown>(() => {});
const y = AFunction<
    (arg: string) => unknown
>(() => {});

The first unknown is colored but the second unknown is not for some reason.

Originally posted by @PythonCoderAS in https://github.com/microsoft/vscode/issues/199861

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

No source file or test is named. Start by reproducing the TypeScript grammar highlighting with the single-line and multiline generic calls shown in the issue; done when the unknown type is colored consistently in both forms.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
tooling
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.