microsoft / microsoft/TypeScript-Sublime-Plugin

Plugin's typescript_format_brackets overrides Sublime's default unfold keybinding

Open
#753 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
JavaScript
Stars
1.7k
Forks
236
Avg merge
21d 13h
Merged PRs (30d)
1

Description

Sublime's default keybindings

	{ "keys": ["ctrl+shift+["], "command": "fold" },
	{ "keys": ["ctrl+shift+]"], "command": "unfold" },

fold and unfold code, like this:

image

In https://github.com/microsoft/TypeScript-Sublime-Plugin/blob/a0d393af5714af3ea417239efce22c4db647502b/Default.sublime-keymap#L173-L174

the TypeScript plugin overrides the unfold, so you can no longer unfold code after folding it.

Does it make sense to override a default keybinding this way?

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with Default.sublime-keymap at lines 173-174 and compare the TypeScript plugin's unfold binding with Sublime's default fold and unfold bindings shown in the issue. Verify the key behavior in Sublime Text after the binding is adjusted so folding and unfolding work as expected.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
tooling
Issue type
Bug
Difficulty
1/5
Estimated time
Under an hour
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.