microsoft / microsoft/Tools-for-Health-Data-Anonymization

Shared functional tests are not run

Open
#243 0 comments 1 reaction 1 assignee View on GitHub

Nobody has claimed this yet.

Dominant language
C#
Stars
309
Forks
90
PR merge metrics
No merged PRs in 30d

Description

Release yml includes

  testProjects: "**/*Tests/*.csproj"
  publishProject: "**/*Tool/*.csproj"

https://github.com/microsoft/Tools-for-Health-Data-Anonymization/blob/master/release.yml#L9

But not the functional tests in "shared" projects.
https://github.com/microsoft/Tools-for-Health-Data-Anonymization/blob/master/FHIR/src/Microsoft.Health.Fhir.Anonymizer.Shared.FunctionalTests/Microsoft.Health.Fhir.Anonymizer.Shared.FunctionalTests.shproj

This should be added since I found a failing test that was only visible if run manually.

NOTE: #246 multi target build is in review and changes how tests are run, this should be taken in consideration

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.