microsoft / microsoft/TRELLIS

Integer overflow in slat decoding

Open
#95 4 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Python
Stars
13.7k
Forks
1.3k
PR merge metrics
No merged PRs in 30d

Description

Hi,

Thank you for the enormous efforts in open-sourcing this amazing project!

I'm testing the model on some in-the-wild images. Most images work fine, but on a small number of images there is the following error:

[Exception|implicit_gemm]feat=torch.Size([7342720, 192]),w=torch.Size([96, 3, 3, 3, 192]),pair=torch.Size([27, 7342720]),act=7342720,issubm=True,istrain=True

Upon further investigation it seems like there is an overflow occurring for the underlying spconv library:

/home/ruiningli/spconv/spconv/build/core_cc/src/cumm/conv/main/ConvMainUnitTest/ConvMainUnitTest_matmul_split_Ampere_f16f16f16_0.cu(294)                                                                                                             
int64_t(N) * int64_t(C) * tv::bit_size(algo_desp.dtype_a) / 8 < int_max assert faild. your data exceed int32 range. this will be fixed in cumm + nvrtc (spconv 2.2/2.3).

I'm wondering if anyone has encountered the same during training / inference, and how I might be able to get around this.

Many thanks!
Ruining

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the failure during slat decoding with an affected in-the-wild image, then trace the implicit_gemm call associated with the reported spconv assertion. Done means the affected images decode without the integer-overflow failure, or the supported workaround and limitation are documented.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
machine-learning
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.