microsoft / microsoft/SqlNexus
Best Practice Summary may incorrectly state Power Plan issue.
Open
@gambit9009 is already working on this.
Since Mar 17, 2022.
bug
- Dominant language
- C#
- Stars
- 427
- Forks
- 111
- Avg merge
- 3d 42m
- Merged PRs (30d)
- 8
Description
The perfstatsanalysis script creates an sp called "proc_PowerPlan".
if not exists (select * from tbl_PowerPlan where ActivePlanName like '%High Performance%')
So if the power plan name is not fully spelled out like that, it may flag "Power Plan is not set to high performance". But, at least in later Windows, you can rename your power plan. PC manufactures may have their own names for plans, etc. Someone could use the High Perf plan and change settings to it, without renaming it. The actual settings under the power plan, like CPU throttling, are really what we are concerned with, and not the name of the plan.
- Need to consider for SQL Nexus, at least changing the message that server "might not" have proper power plan...and then be helpful and actually concatenate the power plan name we do see in the message. Might help stop having to look up false positives about the server's power plan.
- PSSDiag captures __SQL_Base_Power_Plan_Startup.txt and that appears to be what gets added to tbl_PowerPlan. But also _SQL2019_MiscPssdiagInfo_Startup.OUT captures powerplan in --ServerProperty-- which gets added into tbl_ServerProperties by Nexus. "proc_PowerPlan" consider updating to check both places if one doesn't have it.
- See also DiagManager issue 148 as we may decide to change what we collect. https://github.com/microsoft/DiagManager/issues/148
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.