microsoft / microsoft/SizeBench

Template Foldability diff view should ignore file paths

Open
#24 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
C#
Stars
175
Forks
20
PR merge metrics
No merged PRs in 30d

Description

In this view, the first line difference is only in the source file - this DLL pulls in static libs that use the same cppwinrt version, but different runs of its projector, so it's got both lib1/obj/winrt/base.h and lib2/obj/winrt/base.h. The second difference is actually meaningful (comparing IIDs in queryinterface.)

I'd like to fix the diff view to either ignore the file-path difference in the view, or mask the "noncommon source base path" so only the real differences in code are shown.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the Template Foldability diff view and trace how it compares source file paths. The change is done when differences caused only by noncommon source base paths are masked while meaningful code differences, such as IID comparisons in QueryInterface, remain visible.

Written by the indexing model from the issue text.

Assessment

Tech stack
csharp
Domain
devtools
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.