microsoft / microsoft/SandDance

Selecting data on a graph is not reliable

Open
#679 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
TypeScript
Stars
7.1k
Forks
573
Avg merge
8d 9h
Merged PRs (30d)
4

Description

Hello.

I'd like to report some issues with data selection and filtering in SandDance (it happens in a web version on https://microsoft.github.io/SandDance/app/ as well as Azure Data Studio extension).
IMO, this feature works counterintuitively and feels flaky. Sometimes, all it takes is a one click, and the data point gets selected. Sometimes you have to make several clicks or double clicks for it to finally work. Sometimes it gets stuck somehow - data point is already selected (colored purple), but filtering in a data menu doesn't apply no matter what. I have to reselect different data points and go back to the needed one.

There is also a separate problem with selection when SandDance graph is exported into html file. In that environment selection is broken completely, and js console contains several types of errors:

``` sanddance-embed.js:211 Uncaught TypeError: Cannot read properties of undefined (reading 'source') at Object.onCanvasClick (sanddance-embed.js:211:54) at Object.onLayerClick [as onCanvasClick] (sanddance-explorer.js:39932:60) at sanddance-explorer.js:36575:21 onCanvasClick @ sanddance-embed.js:211 onLayerClick @ sanddance-explorer.js:39932 (anonymous) @ sanddance-explorer.js:36575 setTimeout (async) (anonymous) @ sanddance-explorer.js:36574

sanddance-embed.js:221 Uncaught TypeError: Cannot read properties of undefined (reading 'source')
at Object.onCubeClick (sanddance-embed.js:221:54)
at $322b2f4239e53da8$export$2ec4afd9b3c16a85.onCubeClick (sanddance-explorer.js:39820:50)
at Object.onCubeClick (sanddance-explorer.js:36792:23)
at $c3cb5e962208053a$export$d0d38e7dec7a1a61.inputManager.pickItemCallback (sanddance-explorer.js:36581:17)
at $c3cb5e962208053a$export$d0d38e7dec7a1a61.update (sanddance-explorer.js:15813:73)
at $ef8115e67e148944$export$4143ab5b91744744.update (sanddance-explorer.js:16239:32)
at $ef8115e67e148944$export$4143ab5b91744744._tick (sanddance-explorer.js:16226:18)
at sanddance-explorer.js:16230:111
onCubeClick @ sanddance-embed.js:221
onCubeClick @ sanddance-explorer.js:39820
onCubeClick @ sanddance-explorer.js:36792
inputManager.pickItemCallback @ sanddance-explorer.js:36581
update @ sanddance-explorer.js:15813
update @ sanddance-explorer.js:16239
_tick @ sanddance-explorer.js:16226
(anonymous) @ sanddance-explorer.js:16230
requestAnimationFrame (async)
_tick @ sanddance-explorer.js:16230
(anonymous) @ sanddance-explorer.js:16230
requestAnimationFrame (async)
_tick @ sanddance-explorer.js:16230
(anonymous) @ sanddance-explorer.js:16230
requestAnimationFrame (async)
_tick @ sanddance-explorer.js:16230
(anonymous) @ sanddance-explorer.js:16230
requestAnimationFrame (async)
_tick @ sanddance-explorer.js:16230
(anonymous) @ sanddance-explorer.js:16230
requestAnimationFrame (async)
_tick @ sanddance-explorer.js:16230
(anonymous) @ sanddance-explorer.js:16230
requestAnimationFrame (async)
_tick @ sanddance-explorer.js:16230
(anonymous) @ sanddance-explorer.js:16230
requestAnimationFrame (async)
_tick @ sanddance-explorer.js:16230
(anonymous) @ sanddance-explorer.js:16230
requestAnimationFrame (async)
_tick @ sanddance-explorer.js:16230
(anonymous) @ sanddance-explorer.js:16230
requestAnimationFrame (async)
_tick @ sanddance-explorer.js:16230
(anonymous) @ sanddance-explorer.js:16230
requestAnimationFrame (async)
_tick @ sanddance-explorer.js:16230
(anonymous) @ sanddance-explorer.js:16230
requestAnimationFrame (async)
_tick @ sanddance-explorer.js:16230
(anonymous) @ sanddance-explorer.js:16230
requestAnimationFrame (async)
_tick @ sanddance-explorer.js:16230
(anonymous) @ sanddance-explorer.js:16230
requestAnimationFrame (async)
_tick @ sanddance-explorer.js:16230
(anonymous) @ sanddance-explorer.js:16230
requestAnimationFrame (async)
_tick @ sanddance-explorer.js:16230
(anonymous) @ sanddance-explorer.js:16230
requestAnimationFrame (async)
_tick @ sanddance-explorer.js:16230
(anonymous) @ sanddance-explorer.js:16230
requestAnimationFrame (async)
_tick @ sanddance-explorer.js:16230
(anonymous) @ sanddance-explorer.js:16230
requestAnimationFrame (async)
_tick @ sanddance-explorer.js:16230
(anonymous) @ sanddance-explorer.js:16230
requestAnimationFrame (async)
_tick @ sanddance-explorer.js:16230
(anonymous) @ sanddance-explorer.js:16230
requestAnimationFrame (async)
_tick @ sanddance-explorer.js:16230
(anonymous) @ sanddance-explorer.js:16230
requestAnimationFrame (async)
_tick @ sanddance-explorer.js:16230
(anonymous) @ sanddance-explorer.js:16230
requestAnimationFrame (async)
_tick @ sanddance-explorer.js:16230
(anonymous) @ sanddance-explorer.js:16230
requestAnimationFrame (async)
_tick @ sanddance-explorer.js:16230
(anonymous) @ sanddance-explorer.js:16230
requestAnimationFrame (async)
_tick @ sanddance-explorer.js:16230
(anonymous) @ sanddance-explorer.js:16230
requestAnimationFrame (async)
_tick @ sanddance-explorer.js:16230
(anonymous) @ sanddance-explorer.js:16230
requestAnimationFrame (async)
_tick @ sanddance-explorer.js:16230
(anonymous) @ sanddance-explorer.js:16230
requestAnimationFrame (async)
_tick @ sanddance-explorer.js:16230
(anonymous) @ sanddance-explorer.js:16230
requestAnimationFrame (async)
_tick @ sanddance-explorer.js:16230
(anonymous) @ sanddance-explorer.js:16230
requestAnimationFrame (async)
_tick @ sanddance-explorer.js:16230
(anonymous) @ sanddance-explorer.js:16230
requestAnimationFrame (async)
_tick @ sanddance-explorer.js:16230
(anonymous) @ sanddance-explorer.js:16230
requestAnimationFrame (async)
_tick @ sanddance-explorer.js:16230
(anonymous) @ sanddance-explorer.js:16230
requestAnimationFrame (async)
_tick @ sanddance-explorer.js:16230
(anonymous) @ sanddance-explorer.js:16230
requestAnimationFrame (async)
_tick @ sanddance-explorer.js:16230
(anonymous) @ sanddance-explorer.js:16230

sanddance-embed.js:211 Uncaught TypeError: Cannot read properties of undefined (reading 'source')
at Object.onCanvasClick (sanddance-embed.js:211:54)
at Object.onLayerClick [as onCanvasClick] (sanddance-explorer.js:39932:60)
at sanddance-explorer.js:36575:21

</details>

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce selection and filtering in the SandDance web app, Azure Data Studio extension, and exported HTML. Start with the reported onCanvasClick and onCubeClick errors in sanddance-embed.js and the related calls in sanddance-explorer.js. Done means point selection, filtering, and exported-HTML selection work reliably without the reported errors.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript, typescript
Domain
data-visualization, frontend, web-dev
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
32/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.