microsoft / microsoft/SandDance
Sanddance-explorer 3D mode not working on deckgl ^8.3.7
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 7.1k
- Forks
- 573
- Avg merge
- 8d 9h
- Merged PRs (30d)
- 4
Description
Specs
Node: v12.20.1
React(-dom): v16.14.0
Machine: Tested on MacOS (Big Sur 11.1) and Linux (Fedora 29)
Description
After following the instructions on the readme inside a fresh create-react-app, when switching to 3D mode the chart disappears and I get the following error in the console:
deck: error during drawing of CubeLayer({id: 'LAYER_CUBES'}) TypeError: Cannot read property 'length' of undefined
Fixing @deck.gl/core and @deck.gl/layers at 8.3.7 rather than ^8.3.7 seems to resolve the issue.
See also screenshot below:
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the sanddance-explorer README and reproduce the 3D-mode failure in a fresh create-react-app using the reported Node, React, and deck.gl versions. Compare behavior with @deck.gl/core and @deck.gl/layers pinned to 8.3.7; done means 3D mode renders without the CubeLayer length error when using the supported dependency range.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- react, typescript
- Domain
- data-visualization
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100