microsoft / microsoft/SandDance

Right click handler/renderer for marks

Open
#160 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement good first issue help wanted
Dominant language
TypeScript
Stars
7.1k
Forks
573
Avg merge
8d 9h
Merged PRs (30d)
4

Description

It would be great if we could set a right click handler (or some sort of rendering mechanism) that would allow us to render something when we right click on the mark.

I imagine that 99% of the time this would be for a context menu, but it should be flexible enough to allow for anything to be rendered on right click.

This would take advantage of #159 in that the row and column data, and associated metadata would be passed to this render method.

An example would be the following. Let's say I have the following object used in the explorer:

{
    eventId: 1,
    description: 'some event',
    start: '2019-12-25',
    end: '2019-12-26'
}

Along with the associated metadata for the columns (it's assumed the keys are related to the properties above):

{
    eventId: { adminPageRoot: '/admin/events/' }
}

Then, in the render method, all this information could be put together to render a link with the following URL:

/admin/events/1

Which would allow someone right clicking on that mark to be taken to a page related to that specific mark (and it's type).

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reviewing the existing mark interaction and rendering paths, then read issue #159 to understand the row, column, and metadata context it provides. Done should include a defined right-click rendering or handler mechanism that can receive the associated mark data and support the described context-menu use case.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
data-visualization, frontend
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.