microsoft / microsoft/STL

<execution>, <shared_mutex>: use aliasobj

Open
#801 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

performance
Dominant language
C++
Stars
11.1k
Forks
1.7k
Avg merge
4d 15h
Merged PRs (30d)
22

Description

Due to no need to support XP in import library, this can be handled like #688 :

  1. Threadpool in parallel_algorithms.cpp
  2. Shared mutex in sharedmutex.cpp (need to tune calling conventions)

I think it not worth doing for by handle and symlink APIs in filesystem.cpp or for syserror_import_lib.cpp.

I assume this also cancels #763 , as symbol alias is better than forwarder for forwarding during link time.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reading issue #688 and the threadpool code in parallel_algorithms.cpp. Then inspect sharedmutex.cpp, including its calling conventions, to determine how aliasobj should be applied; leave filesystem.cpp and syserror_import_lib.cpp unchanged as proposed. Done means the selected symbols use aliases consistently and the relationship to issue #763 is resolved.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
build-system
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.