Explicitly enable or disable conformant preprocessor in tests
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 11.1k
- Forks
- 1.7k
- Avg merge
- 4d 15h
- Merged PRs (30d)
- 22
Description
@CaseyCarter noted that in the near future, /std:c++latest is expected to imply /Zc:preprocessor, so we should alter all /std:c++latest configurations to explicitly enable or disable the new preprocessor.
Originally posted by @StephanTLavavej in https://github.com/microsoft/STL/pull/677#issuecomment-611179353
Since /Zc:preprocessor is becoming the default, and we don't explicitly set it, we will see changes in test coverage once it is the default.
We should explicitly enable and disable it to get coverage of both modes.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Search the repository's test configurations for /std:c++latest entries and inspect how compiler options are specified; the issue names no particular file or test entry point. Update the configurations so the new preprocessor is explicitly enabled and disabled, then verify that tests cover both modes.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- build-system, testing-qa
- Issue type
- Refactor
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100