P3923R0 Additional NB Comment Resolutions For Kona 2025
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 11.1k
- Forks
- 1.7k
- Avg merge
- 4d 15h
- Merged PRs (30d)
- 22
Description
WG21-P3923R0 Additional NB Comment Resolutions For Kona 2025
No feature-test macro is mentioned.
- Section 2.1 changes [tuple.helper].
- We already implement this unconditionally. I believe
GH_000545_include_comparewould be the best place to add test coverage for this (instead of adding a whole top-level test).
- We already implement this unconditionally. I believe
- Sections 2.2, 2.3, 2.4, and 2.5 patch
<hive>, which I've recorded in #5301. - Section 2.6 patches the parallel range algorithms, which I've recorded in #5610 (thanks @timsong-cpp).
- Section 2.7 patches
<meta>, which I've recorded in #5606. - Sections 2.8 and 2.9 patch
std::execution, which I've recorded in #4768. - Section 2.10 changes [tuple.tuple.general].
- We already strengthen
noexcepthere, so we just need to remove those comments from product code (and any test comments).
- We already strengthen
I'll mark this as Available as I'm willing to review a PR for sections 2.1 and 2.10 before opening up the general C++26 floodgates.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the issue's sections 2.1 and 2.10, then inspect the existing GH_000545_include_compare coverage and the tuple-related implementation and tests. Add coverage for the [tuple.helper] change, and remove the obsolete comments associated with [tuple.tuple.general] from product code and tests. Done means those two sections are addressed without opening separate work already tracked in the linked issues.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- devtools
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 42/100