`VSO_0744055_atomic_load_8_bytes_readonly` test can be improved
Open
Nobody has claimed this yet.
test
- Dominant language
- C++
- Stars
- 11.2k
- Forks
- 1.7k
- Avg merge
- 4d 15h
- Merged PRs (30d)
- 22
Description
Two unrelated improvements possible:
Test the same thing for 128-bit atomic on x64. it was also initially implemented with cx16-based load, but now with SSE2, so the same issue appliesnot yet, actually, see #4480- It has UB and that is commented in the test, but with
atmoic_refit can be avoided
Not sure if either are worth doing. It is an old test for customer's situation, so may be preserved as it is.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Locate the VSO_0744055_atomic_load_8_bytes_readonly test and read its comment about undefined behavior. Check the proposed atomic_ref change and #4480 before confirming with maintainers whether the 128-bit case is out of scope; completion requires an agreed scope and a passing targeted test.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- testing-qa
- Issue type
- Refactor
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100