microsoft / microsoft/STL

`<filesystem>`: Do we need to handle Volume GUID Paths?

Open
#5,034 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug filesystem
Dominant language
C++
Stars
11.1k
Forks
1.7k
Avg merge
4d 15h
Merged PRs (30d)
22

Description

See Naming a Volume in the Win32 docs.

This previously came up in #4291 addressed by #4311, but that fix didn't alter how we parse paths.

@xiangfan-ms observed that we never attempt to handle such paths:

https://github.com/microsoft/STL/blob/2c9e3e7f10366dbd93a16da73264464c8478cdcb/stl/inc/filesystem#L569-L572

It's unclear to me how extensively we'd need to alter our code to handle volume GUID paths, but they appear to be cromulent so this appears to be a bug.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the path-parsing code in stl/inc/filesystem around lines 569-572 and the Win32 “Naming a Volume” documentation linked in the issue. Review #4291 and #4311 to understand the prior handling and determine the scope of Volume GUID path support. Done means the implementation correctly handles the relevant Volume GUID paths without regressing existing path parsing.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
operating-systems
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.