`<memory_resource>`: `null_memory_resource` shouldn't have `extern "C"` linkage
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 11.1k
- Forks
- 1.7k
- Avg merge
- 4d 15h
- Merged PRs (30d)
- 22
Description
Describe the bug
According to [using.linkage]/1, std::pmr::null_memory_resource needs to have extern "C++" linkage, but MSVC STL currently gives it extern "C" linkage.
Additional context
null_memory_resource is currently dll-exported, so changing it to have extern "C++" linkage would break binary compatibility.
vNext note: Resolving this issue will require breaking binary compatibility. We won't be able to accept pull requests for this issue until the vNext branch is available. See #169 for more information.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at stl/inc/memory_resource around the linked location and review the declaration of null_memory_resource and its current linkage. Check the vNext branch when it becomes available, then verify that the declaration uses the required C++ linkage while addressing the stated binary-compatibility constraint. There is no test or runnable entry point named in the issue.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- tooling
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 25/100