microsoft / microsoft/STL

Investigate ppltasks dependency for vNext

Open
#3,606 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

vNext
Dominant language
C++
Stars
11.1k
Forks
1.7k
Avg merge
4d 15h
Merged PRs (30d)
22

Description

I'm going to need to revert #2654 and #3255, so here are vNext todos that were mentioned in the latter PR's added comment:

When we can break ABI, we should:

  • In <ppltasks.h>, reconsider whether _Task_impl_base::_Wait() should throw invalid_operation; it's questionable whether that's conforming, and if users want to block their UI threads, we should let them.
  • Investigate whether we can avoid the ppltasks dependency entirely, making all of these issues irrelevant.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the vNext TODOs and the references to PRs #2654 and #3255. Read <ppltasks.h>, focusing on _Task_impl_base::_Wait(), then investigate whether the ppltasks dependency can be removed entirely. Done means resolving the dependency question and determining whether the _Wait() behavior should change when ABI breaks.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
compilers
Issue type
Refactor
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.