microsoft / microsoft/STL

<type_traits>: aligned_storage should always support extended alignments

Open
#297 0 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement vNext
Dominant language
C++
Stars
11.1k
Forks
1.7k
Avg merge
4d 15h
Merged PRs (30d)
22

Description

To fix a correctness bug, we implemented the following unusual opt-in/opt-out machinery:

https://github.com/microsoft/STL/blob/58bb49d63d92e7a0346a05af29816aeea6b4cf0f/stl/inc/type_traits#L1072-L1094

In vNext, we should simply support extended alignments unconditionally, and eliminate this preprocessor logic.

Also tracked by Microsoft-internal VSO-660008 / AB#660008.

vNext note: Resolving this issue will require breaking binary compatibility. We won't be able to accept pull requests for this issue until the vNext branch is available. See #169 for more information.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with stl/inc/type_traits around lines 1072-1094, linked in the issue, and review the current aligned_storage opt-in/opt-out preprocessor logic. This work is blocked until the vNext branch is available; done means unconditionally supporting extended alignments and eliminating that logic, with the required binary-compatibility break accounted for.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
compilers
Issue type
Bug
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.