microsoft / microsoft/STL

`<ios>`: `basic_ios::set_rdbuf` is supposed to be `protected`

Open
#2,829 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug vNext
Dominant language
C++
Stars
11.1k
Forks
1.7k
Avg merge
4d 15h
Merged PRs (30d)
22

Description

Describe the bug
Dear STL team,

I think I've found an inconsistency of the implementation with the standard.
According to https://en.cppreference.com/w/cpp/io/basic_ios/set_rdbuf and the diagnostic I'm seeing on clang and g++ basic_ios::set_rdbuf is supposed to be protected, but is public in this implementation.

Kind regards

Konstantin

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the basic_ios::set_rdbuf declaration in the STL implementation and compare its access level with the C++ standard and the clang/g++ diagnostic described in the issue. Done means the declaration matches the required protected access and the relevant library tests confirm the correction.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
compilers
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.