<xtimec.h>: Stop exporting internal-only functions
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 11.1k
- Forks
- 1.7k
- Avg merge
- 4d 15h
- Merged PRs (30d)
- 22
Description
Of these functions, xtime_get() and _Xtime_diff_to_millis2() are used within src only; there's no need for them to be exported.
Furthermore, _Xtime_diff_to_millis() is completely unused and should be removed.
Changing the export surface is a binary compatibility break, so this is a vNext issue.
vNext note: Resolving this issue will require breaking binary compatibility. We won't be able to accept pull requests for this issue until the vNext branch is available. See #169 for more information.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with stl/inc/xtimec.h lines 28-37 and search the src directory for xtime_get(), _Xtime_diff_to_millis2(), and _Xtime_diff_to_millis(). On the vNext branch, confirm that the first two are no longer exported and the unused function is removed; binary compatibility must be intentionally changed.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- tooling
- Issue type
- Refactor
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 25/100