microsoft / microsoft/STL

STL: lack of test coverage for differing `/Zc:alignedNew`

Open
#2,713 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

test
Dominant language
C++
Stars
11.1k
Forks
1.7k
Avg merge
4d 15h
Merged PRs (30d)
22

Description

In what language modes does the STL support /Zc:alignedNew and/or /Zc:alignedNew-?

language mode /Zc:alignedNew /Zc:alignedNew- Note
C++14 ??? Yes clang-cl (but not cl) allows /std:c++14 /Zc:alignedNew
C++17 Yes Maybe
C++20 Yes Maybe
C++23 Yes Maybe

Once this is decided, we should:

  1. Enforce that __cpp_aligned_new has a supported value for the current language mode if there are unsupported combinations.
  2. Add test coverage if we decide to support any of the non-Yes combinations in the table above (we already cover all of the Yeses). At least "C++14 with aligned new" (if we choose to support that) and "C++latest without aligned new".

Related: DevCom-1346191, DevCom-10036384.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reviewing the existing STL tests for /Zc:alignedNew and the language-mode test setup. Determine the supported combinations for /Zc:alignedNew and /Zc:alignedNew-, then define the expected __cpp_aligned_new behavior and add coverage for any newly supported combinations, including C++14 with aligned new or C++latest without it if applicable.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
compilers, testing-qa
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.