microsoft / microsoft/STL

<xlocale>: codecvt_base::result should be an enum type

Open
#266 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug vNext
Dominant language
C++
Stars
11.2k
Forks
1.7k
Avg merge
4d 15h
Merged PRs (30d)
22

Description

https://github.com/microsoft/STL/blob/58c5c4d628abeb22b0028ff479853d7d8212d8a7/stl/inc/xlocale#L664-L670

https://eel.is/c++draft/locale.codecvt mandates enum result { ok, partial, error, noconv };.

(Standardese citations as of WG21-N4835.)

vNext note: Resolving this issue will require breaking binary compatibility. We won't be able to accept pull requests for this issue until the vNext branch is available. See #169 for more information.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Inspect stl/inc/xlocale around lines 664-670 and compare codecvt_base::result with the locale.codecvt requirement in WG21-N4835. This work depends on the vNext branch because it breaks binary compatibility; done means the result type conforms to the cited enum specification there.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
compilers
Issue type
Bug
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.