<xiosbase>: _Iosb shouldn't be necessary anymore
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 11.1k
- Forks
- 1.7k
- Avg merge
- 4d 15h
- Merged PRs (30d)
- 22
Description
This machinery shouldn't be necessary anymore (at least in C++17; hopefully C++14 is sufficiently powerful). We should investigate removing it in vNext.
Additionally, the constants _Nocreate and _Noreplace appear to be unused (they're implemented, but nothing internally appears to pass them as arguments). As they were never documented, we should remove them.
vNext note: Resolving this issue will require breaking binary compatibility. We won't be able to accept pull requests for this issue until the vNext branch is available. See #169 for more information.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with stl/inc/xiosbase, especially lines 24-169, and inspect how _Iosb, _Nocreate, and _Noreplace are used. Check the vNext branch and #169 before proceeding, since the change requires breaking binary compatibility. Done means removing the unnecessary machinery and unused constants without leaving internal callers dependent on them.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- compilers
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 25/100