microsoft / microsoft/STL

`<vector>`, etc.: avoid `_RERAISE` in favor of usual scope guards

Open
#2,307 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement
Dominant language
C++
Stars
11.1k
Forks
1.7k
Avg merge
4d 15h
Merged PRs (30d)
22

Description

_RERAISE; expands to throw;, that is it rethrowing an exception.

This is used for cleanups in exception case.

It is inconvenient for debugging, when the same exception shows up twice.
Change this construct to usual scope guards.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating _RERAISE uses in <vector> and the other headers covered by the issue, then inspect how those uses perform exception cleanup. Replace the construct with the project’s usual scope guards and verify that cleanup preserves behavior without rethrowing the same exception for debugging.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
backend
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.