<vector>: vector<bool> iterators aren't SCARY
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 11.1k
- Forks
- 1.7k
- Avg merge
- 4d 15h
- Merged PRs (30d)
- 22
Description
Long ago, we made most of our iterators SCARY (see WG21-N2911 and WG21-N2980). However, vector<bool> iterators still depend on the allocator:
We should fix this in vNext, as we already need to rewrite vector<bool> iterators to eliminate the container proxy.
vNext note: Resolving this issue will require breaking binary compatibility. We won't be able to accept pull requests for this issue until the vNext branch is available. See #169 for more information.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with stl/inc/vector at the linked lines and review the SCARY iterator references in WG21-N2911 and WG21-N2980. Check #169 and wait for the vNext branch before making changes, since the issue notes that binary compatibility must be broken. Done means vector iterators no longer depend on the allocator and the container proxy is eliminated.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- tooling
- Issue type
- Refactor
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 25/100