Consider adding a test with `/analyze:plugin EspXEngine.dll`
A pull request for this has already been merged.
- #2116 by @AlexGuteniev — merged
- Dominant language
- C++
- Stars
- 11.1k
- Forks
- 1.7k
- Avg merge
- 4d 15h
- Merged PRs (30d)
- 22
Description
There's already /analyze option:
/analyze:plugin EspXEngine.dll could be added to add C++ Core Guidelines check.
See more: Use the C++ Core Guidelines checkers
As an example #2069 changes can be enforced: https://godbolt.org/z/jfx9dzb1T
It may produce too many warnings that won't b addressed though. These can be suppressed either by ordinary suppression or by [[gsl::suppress(...)]] attribute.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with azure-devops/cmake-configure-build.yml at the existing /analyze option and read the linked C++ Core Guidelines checker documentation. Compare the proposed checks with the changes in #2069 and determine how warnings should be handled or suppressed. Done means the analyzer test is added without leaving unresolved warnings.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cmake, cpp
- Domain
- build-system, ci-cd, testing-qa
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100