<yvals_core.h>: Remove _HAS_STD_BYTE someday
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 11.1k
- Forks
- 1.7k
- Avg merge
- 4d 15h
- Merged PRs (30d)
- 22
Description
After microsoft/GSL#821 "gsl_byte should inspect __cpp_lib_byte in addition to _HAS_STD_BYTE" is fixed, _HAS_STD_BYTE should no longer be needed for detection.
After the Windows SDK's unqualified mentions of byte (referring to their own ::byte) are fixed, _HAS_STD_BYTE should no longer be needed for control.
Then we can finally remove:
Also, I created microsoft/GSL#1145 so that GSL will no longer inspect _HAS_STD_BYTE at all.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Read the linked stl/inc/yvals_core.h lines 475-477 and verify the prerequisite fixes in microsoft/GSL#821 and microsoft/GSL#1145, along with the Windows SDK's unqualified byte references. Done means _HAS_STD_BYTE is no longer needed for detection or control and the affected STL and GSL checks remain valid.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- backend
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 25/100