microsoft / microsoft/STL

STL: Finish cleaning up the MRTDLL macro

Open
#185 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

blocked enhancement
Dominant language
C++
Stars
11.2k
Forks
1.7k
Avg merge
4d 15h
Merged PRs (30d)
22

Description

The MRTDLL macro (which stands for "Managed RunTime DLL", I believe) is defined by our Microsoft-internal MSBuild-powered build system when building various flavors of the STL for managed code; the GitHub CMake/Ninja-powered build system doesn't yet build /clr binaries, so it doesn't define MRTDLL. We've recently cleaned up most usage of this macro, as changes over the years have dramatically simplified when it is defined. There are a few remaining occurrences that we should be able to clean up without physically changing any behavior, but more investigation is required.

Note: This is blocked until we port the /clr build to CMake/Ninja.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the remaining MRTDLL occurrences and reviewing how the Microsoft-internal MSBuild and GitHub CMake/Ninja builds define it. The issue is done when the remaining uses are cleaned up without changing behavior, after the /clr build has been ported to CMake/Ninja.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
build-system
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
20/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.