microsoft / microsoft/STL

<coroutine>: Enhance test coverage

Open
#1,224 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

test
Dominant language
C++
Stars
11.1k
Forks
1.7k
Avg merge
4d 15h
Merged PRs (30d)
22

Description

We've added an "end-to-end" test for <coroutine>, which will be active when the compiler updates its feature-test macro (expected in VS 2019 16.8 Preview 4):

https://github.com/microsoft/STL/blob/484fbc9742f895030047977efc55dc8950a37086/tests/std/tests/P0912R5_coroutine/test.cpp#L90-L96

When that toolset is available, we should consider enhancing this test coverage to cover all of the machinery in <coroutine>. For example, this isn't testing spaceship/hash:

https://github.com/microsoft/STL/blob/484fbc9742f895030047977efc55dc8950a37086/stl/inc/coroutine#L127-L137

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with tests/std/tests/P0912R5_coroutine/test.cpp, especially the existing end-to-end test, and inspect stl/inc/coroutine to identify the remaining machinery. When the referenced toolset feature-test macro is available, expand coverage to the untested coroutine components, including the spaceship and hash functionality mentioned in the issue.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
testing-qa
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.