microsoft / microsoft/STL

<complex>: Remove complex<NonFloating>

Open
#1,078 5 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement
Dominant language
C++
Stars
11.1k
Forks
1.7k
Avg merge
4d 15h
Merged PRs (30d)
22

Description

std::complex<NonFoating> does not work as user may expect.

The Standard only specifies the behavior of std::complex<T> for cv-unqualified floating-point types T, so the implementation can have any behavior in this case, ranging from not compiling the instantiation at all to full support of non-standard floating-point types.

See #756 for more context.

An attempt was made to deprecate this extension.
It did not work due to Real World Code test suite failing on NVIDIA/cutlass#104
See #889

This enhancement is the complete removal of the primary template.
This is the ultimate version of #756 enhancement.
This is not acceptable currently, but may be acceptable for ABI-breaking release.

vNext note: Resolving this issue will require breaking binary compatibility. We won't be able to accept pull requests for this issue until the vNext branch is available. See #169 for more information.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

This issue is blocked until the vNext branch is available because resolving it breaks binary compatibility. Start by reading #756, #889, and #169, and review the NVIDIA/cutlass#104 compatibility failure; done means the primary template is removed in the vNext context without repeating that failure.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
compilers
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
20/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.