microsoft / microsoft/SPTAG

Parallel problem during BKT building

Open
#74 0 comments 0 reactions 1 assignee View on GitHub

@MaggieQi is already working on this.

Since Jul 10, 2019.

customer raised question
Dominant language
C++
Stars
5k
Forks
622
Avg merge
8h 37m
Merged PRs (30d)
5

Description

Inside the KmeansAssign function during the BKT building stage, it seems like it tries to parallel the job amount the threads (if set the NumberOfThreads to more than 1)
企业微信截图_20190705140313
However, as the omp_get_num_threads() would only return 1 outside the "omp parallel for" loop, the function actually never parallel the job.
I'm not sure if this is done on purpose (since the BKT build wouldn't take much time, so no need to parallel?) or just a small bug.
I've also tried to use omp_get_max_thread() instead of omp_get_num_threads() to make use of the parallel. However, there is some kind of a bug that would just end the build process without any error message.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.